-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Extract test fixtures to separate header #55056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
motiz88
wants to merge
2
commits into
facebook:main
Choose a base branch
from
motiz88:export-D90174645
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+442
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca830a9 to
f4f1b78
Compare
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Jan 6, 2026
Summary: Pull Request resolved: facebook#55056 Refactors InspectorPackagerConnectionTest.cpp to extract the test fixtures into a separate header file. This allows us to split `InspectorPackagerConnectionTest.cpp` into multiple files as we add more test cases, which is particularly helpful for LLMs writing tests. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D90174645
f4f1b78 to
2a0587d
Compare
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Jan 13, 2026
Summary: Pull Request resolved: facebook#55056 Refactors InspectorPackagerConnectionTest.cpp to extract the test fixtures into a separate header file. This allows us to split `InspectorPackagerConnectionTest.cpp` into multiple files as we add more test cases, which is particularly helpful for LLMs writing tests. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D90174645
2a0587d to
5db25b2
Compare
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Jan 14, 2026
Summary: Pull Request resolved: facebook#55056 Refactors InspectorPackagerConnectionTest.cpp to extract the test fixtures into a separate header file. This allows us to split `InspectorPackagerConnectionTest.cpp` into multiple files as we add more test cases, which is particularly helpful for LLMs writing tests. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D90174645
5db25b2 to
f812796
Compare
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Jan 16, 2026
Summary: Pull Request resolved: facebook#55056 Refactors InspectorPackagerConnectionTest.cpp to extract the test fixtures into a separate header file. This allows us to split `InspectorPackagerConnectionTest.cpp` into multiple files as we add more test cases, which is particularly helpful for LLMs writing tests. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D90174645
Summary: Pull Request resolved: facebook#55055 TSIA. Changelog: [Internal] Differential Revision: D90174644 Reviewed By: robhogan
Summary: Pull Request resolved: facebook#55056 Refactors InspectorPackagerConnectionTest.cpp to extract the test fixtures into a separate header file. This allows us to split `InspectorPackagerConnectionTest.cpp` into multiple files as we add more test cases, which is particularly helpful for LLMs writing tests. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D90174645
f812796 to
72eae59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
meta-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactors InspectorPackagerConnectionTest.cpp to extract the test fixtures into a separate header file. This allows us to split
InspectorPackagerConnectionTest.cppinto multiple files as we add more test cases, which is particularly helpful for LLMs writing tests.Changelog: [Internal]
Reviewed By: robhogan
Differential Revision: D90174645